Skip to content

Remove unused uuid devDependency#374

Merged
umair-ably merged 1 commit intomainfrom
chore/remove-unused-uuid-dep
Apr 27, 2026
Merged

Remove unused uuid devDependency#374
umair-ably merged 1 commit intomainfrom
chore/remove-unused-uuid-dep

Conversation

@umair-ably
Copy link
Copy Markdown
Collaborator

Summary

  • The uuid package is listed in devDependencies but is never imported anywhere in the codebase.
  • All UUID generation (in src/base-command.ts, src/commands/auth/*, and several test helpers) uses Node's built-in randomUUID() from node:crypto.
  • The only textual occurrence — a comment in test/helpers/e2e-mutable-messages.ts describing the format "e2e-mutable:<suffix>-<uuid>" — uses the word generically, not the package.

This also makes the open Dependabot bump to uuid@14 redundant.

Test plan

  • pnpm prepare succeeds
  • pnpm exec eslint . — 0 errors
  • pnpm test:unit — 2295 passing

The uuid package was listed in devDependencies but never imported
anywhere. ID generation across src/ and test/ uses Node's built-in
randomUUID() from node:crypto, so this dep is dead weight.
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 27, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
cli-web-cli Ready Ready Preview, Comment Apr 27, 2026 8:52am

Request Review

@claude-code-ably-assistant
Copy link
Copy Markdown

Walkthrough

This PR removes the uuid package from devDependencies, which was listed as a dependency but never actually imported anywhere in the codebase. All UUID generation across src/ and test/ already uses Node's built-in crypto.randomUUID(), making the package dead weight. As a side effect, this also makes the pending Dependabot bump to uuid@14 redundant.

Changes

Area Files Summary
Config package.json Removed uuid@^13.0.0 from devDependencies
Config pnpm-lock.yaml Removed uuid@13.0.0 lockfile entry and snapshot; also picks up libc field additions for several @rolldown, lightningcss, and @rollup platform-specific packages

Review Notes

  • No behavioral changes — this is a pure dependency removal with no source code modifications.
  • pnpm-lock.yaml noise: Beyond the uuid removal, the lockfile diff includes libc: [glibc] / libc: [musl] annotations added to several unrelated platform-specific packages (@rolldown/*, lightningcss-*, @rollup/*). These appear to be a side effect of regenerating the lockfile with a newer pnpm version and are not concerning, but reviewers should be aware they are not part of the intentional change.
  • Dependabot: The open Dependabot PR for uuid@14 (chore(dev-deps): bump uuid from 13.0.0 to 14.0.0 #371 or similar) can be closed after this merges.
  • No new dependencies, no migration steps, no test coverage gaps — the existing 2295-passing unit test suite covers the relevant code paths.

Copy link
Copy Markdown

@claude-code-ably-assistant claude-code-ably-assistant Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: Remove unused uuid devDependency

No issues found. This PR is correct and clean.

Verification

Claim Status
uuid package not imported anywhere Confirmed — no from 'uuid' or require('uuid') in src/ or test/
All UUID generation uses node:crypto Confirmed — randomUUID imported from node:crypto in 5 files
Only uuid text occurrence is a comment Confirmed — test/helpers/e2e-mutable-messages.ts comment uses the word generically
Lock file changes are consistent The pnpm-lock.yaml diff correctly removes the uuid@13.0.0 entry and snapshot; the additional libc field additions on @rolldown/binding-* entries are unrelated incidental lockfile normalization

Assessment

Straightforward dead dependency removal — no behavioral change, no test impact, no risk. The uuid package was never used; Node's built-in crypto.randomUUID() has been the actual implementation throughout. Also eliminates the open Dependabot bump to uuid@14 which would otherwise be noise.

@umair-ably umair-ably enabled auto-merge April 27, 2026 09:04
@umair-ably umair-ably merged commit c672952 into main Apr 27, 2026
13 checks passed
@umair-ably umair-ably deleted the chore/remove-unused-uuid-dep branch April 27, 2026 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants