fix: reject gRPC message without a messageId #569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I also saw this error, and was planning on working on it this morning. I think the TCK looks for an InvalidParamsError, so we need the mapper to throw that somehow EDIT: nm, I see you have changed the mapper :-) |
kabir
requested changes
Jan 6, 2026
| @Named("requireNonEmpty") | ||
| default String requireNonEmpty(String value) { | ||
| if (value == null || value.isEmpty()) { | ||
| throw new IllegalArgumentException("Required field cannot be null or empty"); |
Collaborator
There was a problem hiding this comment.
I think this should be InvalidParamsError since that is what the TCK tests for
Failure is reported in the TCK by the tests/optional/features/test_invalid_business_logic.py::test_missing_required_message_fields test. Signed-off-by: Jeff Mesnil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failure is reported in the TCK by the tests/optional/features/test_invalid_business_logic.py::test_missing_required_message_fields test.