Conversation
… relationship with (#330) The PATCH half of #330 was fixed in #421: a patch that moves a chart-scoped row to a chart the caller has no relationship with is refused, gated on the row as patched. The issue left CREATE as an open question because the same gate would break the one workflow that needs to name an unrelated chart - triaging an inbox of unclaimed faxes, which by definition has no prior relationship, the same argument `care-relationship.ts` already accepts for reception and billing. Settling it as "yes, as triage needs": create stays ungated on the chart it names, `POST /documents/:id/file` already relies on exactly this, and a create grants no read back on its own. Recorded where the omission is, in `crud.ts`, and locked in with a test naming the decision so a later change does not "fix" this into breaking the triage workflow without the question being reopened.
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
ankit-yc
approved these changes
Sep 12, 2026
ankit-yc
left a comment
Contributor
There was a problem hiding this comment.
Reviewed exact head a7cea5b. The test locks the deliberate create behavior from #330 at the generated seam, and the rationale matches the documented fax-triage workflow. Local API lint, type-check, full test suite, build, formatting, and diff check passed. The remaining CI failure is the repeated SonarCloud JRE-metadata HTTP 403 before analysis, also present on the prior API PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /documents/:id/file) already relies on naming a chart with no prior relationship, and a create grants no read back on its own.crud.ts, and added a test inroutes.orders.test.tsnaming the decision so it isn't mistaken for an oversight later.Test plan
pnpm --filter api lintpnpm --filter api type-checkpnpm --filter api test(4171 passed, 14 skipped)pnpm run format:checkpnpm verifyguardChartcall to CREATE, new test failed as expected (404 vs 201), reverted