Open
Conversation
…ndroid into epic/ANDR-31
kish-dev
reviewed
Mar 21, 2026
|
|
||
| sealed interface ProfileEvent { | ||
|
|
||
| data class SocialNetworkOpened( |
Collaborator
There was a problem hiding this comment.
Тоже название через OnSocialNetworkClicked или что-то такое
kish-dev
reviewed
Mar 21, 2026
| ) | ||
| userData: DomainUserProfile, | ||
| ): ProfileScreenState = | ||
| ProfileScreenState.Success( |
Collaborator
There was a problem hiding this comment.
А у нас разве тут не можешь быть ошибочного состояния, состояния загрузки? Кажется, этим всем должен заправлять именно маппер
kish-dev
reviewed
Mar 21, 2026
| throw ce | ||
| } catch (e: IOException) { | ||
| Timber.e(e, "Network error in mapper") | ||
| ProfileScreenState.Error( |
Collaborator
There was a problem hiding this comment.
Тоже надо прокидывать в маппер. Как вариант, просто кидать эксепшион как ошибку в маппер, остальное - как null. Важно, чтобы вся обработка была в маппере
kish-dev
requested changes
Mar 21, 2026
kish-dev
reviewed
Mar 23, 2026
| ) | ||
| ) | ||
|
|
||
| fun mapToLoading(): ProfileScreenState.Loading = ProfileScreenState.Loading |
Collaborator
There was a problem hiding this comment.
private fun, у нас одна точка входа - функция map
kish-dev
requested changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧩 Что сделано:
🗂 Затронутые модули:
feature -> profile -> impl