move pynq import to detect_devices function - #8
Open
skalade wants to merge 1 commit into
Open
Conversation
Collaborator
|
we should consider a refactor to move devices discovery fully into pynqutils ... I see a split between device discovery and runtime-access this PR is good, but hopefully we can remove |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now trying to import pynqutils on a system without pynq installed results in an import error due to the import from https://github.com/Xilinx/PYNQ-Utils/blob/main/pynqutils/runtime/__init__.py#L4
This change would allow us to import pynqutils on x86 or other systems without needing to install pynq.