Repository navigation
fix(tui): stop pinning actor send on the Delegating pending label - #2681
Merged
Merged
Conversation
actor send/status/wait/cancel/models have no description field, so InlineTool's complete=resolvedDescription() stayed falsy and the row never left "~ Delegating...". Key the pending fallback and body off the action (and to_actor_id for send) instead.
A send can complete with title "Send failed: receiver not found", and any actor action can land on partStatus error. Prefer the tool failure title and keep past-tense success labels off those outcomes.
ActorTool emits completed titles like "Actor wait: timeout" / "Actor cancel: unknown" without the word "fail". Detect those so the row never claims "Waited for" / "Cancelled" on a non-success terminal.
Match the wait row shape users already read: Waiting for — <actor desc> Waiting/Sent message to — <actor desc> Drop the one-off "Sent to id — content preview" body. Resolve the send target's registry description the same way wait does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
actortool row forsend(and other actions without adescription) stayed on the generic~ Delegating...pending label forever, becauseInlineToolonly left that fallback whenresolvedDescription()was truthy — andsendhas no description field.to_actor_id/actor_id/ tool title, and render send on the sameLabel — actor descshape as wait (desktop wording: "Send message to subtask"):Sending message to — <actor desc>Sent message to — <actor desc>Send message failed — <actor desc>Send failed: …,partStatus=error, and wait/runtimeout|interrupted|unknownkeep failure wording.Verification
bun test test/cli/tui/actor-tool-state.test.ts— PASSactor-status,actor-notification-warnings,actor-send,actor) — PASSbun run typecheck— PASSNo feature spec (small mechanical TUI fix).