Fixed primary key too long identifier name#124
Open
rtorralba wants to merge 2 commits intoXethron:masterfrom
Open
Fixed primary key too long identifier name#124rtorralba wants to merge 2 commits intoXethron:masterfrom
rtorralba wants to merge 2 commits intoXethron:masterfrom
Conversation
Author
|
I executed your project phpunit tests locally and fails too: There was 1 error:
I can't access to the travis execution log for view what exactly fails. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When index is primary the index name is always 'PRIMARY', then is not necessary to check isDefaultIndexName. If you don't set index name, try to make a index identifier joining (implode) all fields of the key and if this field is bigger than 64 characters it fail