Skip to content

Fixed primary key too long identifier name#124

Open
rtorralba wants to merge 2 commits intoXethron:masterfrom
rtorralba:master
Open

Fixed primary key too long identifier name#124
rtorralba wants to merge 2 commits intoXethron:masterfrom
rtorralba:master

Conversation

@rtorralba
Copy link
Copy Markdown

When index is primary the index name is always 'PRIMARY', then is not necessary to check isDefaultIndexName. If you don't set index name, try to make a index identifier joining (implode) all fields of the key and if this field is bigger than 64 characters it fail

@rtorralba
Copy link
Copy Markdown
Author

I executed your project phpunit tests locally and fails too:

There was 1 error:

  1. Xethron\MigrationsGenerator\MigrationsGeneratorServiceProviderTest::registers_migrations_generator
    BadMethodCallException: Method Mockery_0_stdClass::singleton() does not exist on this mock object

I can't access to the travis execution log for view what exactly fails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant