Skip to content

Fix choice value i18n lookup - #307

Open
pavelhoral wants to merge 1 commit into
WrenSecurity:mainfrom
pavelhoral:fix-choice-i18n
Open

Fix choice value i18n lookup#307
pavelhoral wants to merge 1 commit into
WrenSecurity:mainfrom
pavelhoral:fix-choice-i18n

Conversation

@pavelhoral

@pavelhoral pavelhoral commented Jun 10, 2026

Copy link
Copy Markdown
Member

This PR changes how the SELECT choice value localization is being performed.

The main reason for looking into this was untranslated iPlanetAMAuthService service dynamic profile field translation. The translation of values for this field is being stored in schema localization. However the code was using amConsole localization bundle for choice translation.

Original behavior:

  • always use amConsole localization for select choice values with fallback to the choice value itself

Updated behavior:

  • use owner schema localization for select choice values with fallback to amConsole and the choice value itself
    • fallback to amConsole is there as some translations are global and not service-specific (e.g. SCRIPT selection label, boolean value translation true=Yes/false=No)
  • removed special behavior for SCRIPT select choice (TBH I am not sure why it was there in the first place)

Side-effects of my change:

  • every schema choice is now localized if it is actually being localized in service schema
  • schema localizations are mostly written as descriptions (i.e. full sentences)

Status of this PR / steps before merging:

  • A bunch of new "strange" translations appeared in the UI due to the fact, that service schema translations were written more as full-blown sentences rather than value labels.
  • I would like to make report / list of all changes that happened due to this change. Only then we can make a decision whether to approve this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant