Skip to content

Added a method on Gordon's Stream class to retrieve remaining buffer data#37

Open
tbrebant wants to merge 1 commit intoWizcorp:masterfrom
tbrebant:maintenance
Open

Added a method on Gordon's Stream class to retrieve remaining buffer data#37
tbrebant wants to merge 1 commit intoWizcorp:masterfrom
tbrebant:maintenance

Conversation

@tbrebant
Copy link
Copy Markdown

Added a method on Gordon's Stream class to retrieve remaining buffer data.

Ping @bchevalier @dyoxyne @cstoquer @cainmartin.

@bchevalier
Copy link
Copy Markdown
Contributor

you added a method that is not used?

@tbrebant
Copy link
Copy Markdown
Author

tbrebant commented Dec 1, 2017

Yes, just because it's beautiful😄 !

Joke apart, we are using it in in a tool using JEFF.
Gordon could (should?) be an independent component, no?

@bchevalier
Copy link
Copy Markdown
Contributor

I think it makes sense.
And how is it included? submodule or npm package with npm releases?

@tbrebant
Copy link
Copy Markdown
Author

tbrebant commented Dec 1, 2017

Now we just require it.
But at long term we should npm package it, yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants