chore: move pid/uptime_secs test coverage to e2e test#18
Merged
Nic-dorman merged 1 commit intoWithAutonomi:mainfrom Mar 31, 2026
Merged
Conversation
Remove the integration test for pid and uptime_secs fields from daemon_integration.rs (added by mistake) and extend the e2e node management test command to verify these fields instead. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nodes_status_includes_pid_and_uptimeintegration test fromdaemon_integration.rs(added by mistake — this should be tested end-to-end, not as a Rust integration test)pidanduptime_secsfields in node status responses (present for running nodes, omitted for stopped nodes)Test plan
E2E test run on all three platforms against DEV-01 testnet:
Linux (x86_64)
macOS (Apple Silicon)
Windows 10 (x86_64)
🤖 Generated with Claude Code