feat: improve release process with signing, install scripts, and build fixes#17
Open
feat: improve release process with signing, install scripts, and build fixes#17
Conversation
…d fixes - Add ML-DSA-65 post-quantum signing for all release archives via ant-keygen - Add Windows install script (install.ps1) using irm | iex pattern - Replace winget manifest test with install.ps1 test in install-test workflow - Update release body with install scripts, verification instructions, and DigiCert EV code-signing mention for Windows - Fix musl builds: vendored OpenSSL (unix-only) and cross for aarch64-musl - Fix Windows build: add shell: bash to conditional build step - Skip cargo publish for RC versions - Update bootstrap peers with current production IPs - Update README installation section with install scripts - Add release-signing-key.pub for signature verification Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
Overall: Solid release engineering work. The move to cross for aarch64-musl, ML-DSA-65 signing, and the Windows install script are all good additions. A few items worth addressing: Issues:
Nits:
Looks good overall. The CI/CD changes are well-structured with the new sign-releases job consolidating artifact handling. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ant-keygen, with SHA256 checksumsinstall.ps1) usingirm | iexpattern, matching the existinginstall.shfor Linux/macOScrossfor aarch64-musl)shell: bashfor conditional build step)cargo publishfor RC versions (-rc.tag guard)install.ps1test in install-test workflowresources/release-signing-key.pubfor signature verificationTest plan
ant-cli-v0.1.2-rc.1tag🤖 Generated with Claude Code