added batch19-28 filter - #38
Open
ta4tsering wants to merge 1 commit into
Open
ta4tsering wants to merge 1 commit into
ta4tsering wants to merge 1 commit into
Conversation
tenzin3
reviewed
Jul 26, 2024
| add_row_to_csv(headers, csv_path) | ||
| for image_name in image_list: | ||
| id = image_name | ||
| group_id = "12" |
Member
There was a problem hiding this comment.
-
if you could put neccessary args this way, it would be more convenient when working with other group_ids, same for other args(state,..) as well.
-
if the argument value wont change at all, then import from config file
def get_csv(image_list, batch_id, group_id:str="12"):
......
tenzin3
reviewed
Jul 26, 2024
| from utils import get_image_name, add_row_to_csv | ||
|
|
||
|
|
||
| def get_csv_data(batch_id): |
Member
There was a problem hiding this comment.
add extension for function arguments. for other functions as well
def get_csv_data(batch_id:str):
......
tenzin3
reviewed
Jul 26, 2024
|
|
||
| def get_images(image_keys): | ||
| image_names = [] | ||
| for image_key in image_keys[1:]: |
Member
There was a problem hiding this comment.
one line logical comment on why it is slicing from first element?
Member
|
@ta4tsering test case is failing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.