Enhance Dockerfile and Vite configuration for library integration; re… - #608
Merged
Merged
Conversation
…factor API calls to use library service. Update environment variables for library API and adjust Nginx configuration for proxying library requests. Modify tests to mock new library service functions.
|
…development; enhance segment handling in library service with new functions for fetching related segments and text commentaries. Improve tests for segment relations and ensure accurate counts for translations and commentaries.
…lback options; update environment variables for backend and library services. Enhance pagination logic in Sources component to accurately reflect total matches across pages and improve related tests.
Tech-lo
approved these changes
Sep 10, 2026
…re in chapter components by adding type and reference fields. Integrate ResourceState component for loading and error handling in related texts, root texts, and translation views. Refactor API calls to cache text metadata for improved performance and update tests to reflect new segment structure.
…ce footer behavior for the home page with hover effects, and introduce marquee animation for partner logos. Update tests for footer functionality and adjust series card display in plan viewer. Refactor sections in JoinableGroups and PresetMantras to use SectionHeading for improved consistency.
…ponents for improved responsiveness and visual consistency. Adjust height and spacing properties to enhance overall design.
|
❌ The last analysis has failed. |
| const raw = await fetchContentSearch({ | ||
| query: params.query, | ||
| search_type: searchType, | ||
| limit: MAX_EXTERNAL_SEARCH_LIMIT, |
There was a problem hiding this comment.
Search window truncates pagination
When an exact search has more than 100 openable segment matches, multilingualSearch fetches only the first 100 without forwarding the requested offset, paginates that truncated set locally, and calculates total from it. Results after the first 100 therefore remain unreachable, and a direct request with skip at or above 100 returns no sources despite additional matches.
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/services/library/search.ts
Line: 287
Comment:
**Search window truncates pagination**
When an exact search has more than 100 openable segment matches, `multilingualSearch` fetches only the first 100 without forwarding the requested offset, paginates that truncated set locally, and calculates `total` from it. Results after the first 100 therefore remain unreachable, and a direct request with `skip` at or above 100 returns no sources despite additional matches.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…factor API calls to use library service. Update environment variables for library API and adjust Nginx configuration for proxying library requests. Modify tests to mock new library service functions.