Skip to content

Fix: Prayer Request Multiple prays - #885

Merged
tentamdin merged 5 commits into
developfrom
prayer-request
Oct 5, 2026
Merged

tentamdin merged 5 commits into
developfrom
prayer-request

Conversation

@TenzDelek

@TenzDelek TenzDelek commented Oct 1, 2026 •

Copy link
Copy Markdown
Member

fix #856
Screenshot 2026-10-01 at 11 17 48 AM Screenshot 2026-10-01 at 11 22 36 AM

@greptile-apps

greptile-apps Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 4/5

[Medium risk] Prayer request feature adds multi-prayer support and UI changes.

The PR is not ready to merge because sign-out can still leave accepted prayer taps unsent.

Findings

  1. P1 Sign-out loses queued prayers ▶
Fix with agent prompt
### Issue 1
lib/features/group_chat/presentation/providers/prayer_requests_providers.dart:195-196
If someone closes the prayer sheet and signs out before `_drain` sends their queued taps, the call runs after their credentials are cleared. It fails, and `_drain` drops prayers the button already showed as added. Keep the queued prayers tied to that account, or send them before sign-out.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Reviews (5) · Last reviewed commit: "fix last"

Comment thread lib/features/group_chat/presentation/providers/prayer_requests_providers.dart Outdated
@greptile-apps

This comment has been minimized.

Comment thread lib/features/group_chat/presentation/providers/prayer_requests_providers.dart Outdated
Comment thread lib/features/group_chat/presentation/providers/prayer_requests_providers.dart Outdated
Comment thread lib/features/group_chat/presentation/providers/prayer_requests_providers.dart Outdated
@TenzDelek

Copy link
Copy Markdown
Member Author

@greptileai review

Comment thread lib/features/group_chat/presentation/providers/prayer_requests_providers.dart Outdated
@TenzDelek
TenzDelek requested a review from tentamdin October 1, 2026 07:36
@tentamdin
tentamdin merged commit 7bafe02 into develop Oct 5, 2026
1 of 2 checks passed
@TenzDelek
TenzDelek deleted the prayer-request branch October 5, 2026 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants