fix: padding on the poem and red dot time - #878
Merged
Merged
Conversation
Collaborator
Author
|
|
10zYmon
marked this pull request as ready for review
September 30, 2026 11:21
Contributor
 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Collaborator
Author
Comment on lines
+104
to
+106
| _ticker = Timer.periodic( | ||
| const Duration(minutes: 1), | ||
| (_) => setState(() {}), |
Contributor
There was a problem hiding this comment.
HomeEventBanner starts its one-minute timer when the banner mounts, not at an event's start or end time. If the event changes state between ticks, the dot can appear late or stay visible for up to a minute after the event ends. Recheck at the event's time boundary.
Prompt To Fix With AI
This is a comment left during a code review.
Path: lib/features/home/presentation/widgets/home_header.dart
Line: 104-106
Comment:
**Live dot changes late**
`HomeEventBanner` starts its one-minute timer when the banner mounts, not at an event's start or end time. If the event changes state between ticks, the dot can appear late or stay visible for up to a minute after the event ends. Recheck at the event's time boundary.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
Comment on lines
+72
to
+75
| final languageCode = ref.watch(contentLanguageProvider); | ||
| final isTibetan = AppFontConfig.isTibetanLanguage(languageCode); | ||
| // Tibetan glyphs sit tall above the baseline, so give the title extra room. | ||
| final titleTopPadding = isTibetan ? 20.0 : 8.0; |
Contributor
There was a problem hiding this comment.
PoemStoryPage chooses title spacing from the app's selected content language. The viewer can also fetch a poem by ID without a language filter. If that poem has a Tibetan title while another language is selected, it gets the tighter spacing, so the title can still look cramped. Base the spacing on the title being shown.
Prompt To Fix With AI
This is a comment left during a code review.
Path: lib/features/poems/presentation/widgets/poem_story_page.dart
Line: 72-75
Comment:
**Tibetan title stays cramped**
`PoemStoryPage` chooses title spacing from the app's selected content language. The viewer can also fetch a poem by ID without a language filter. If that poem has a Tibetan title while another language is selected, it gets the tighter spacing, so the title can still look cramped. Base the spacing on the title being shown.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #817