Skip to content

Chore: Tara Additional Requirement - #788

Merged
tentamdin merged 6 commits into
developfrom
new-changes-tara
Sep 17, 2026
Merged

tentamdin merged 6 commits into
developfrom
new-changes-tara

Conversation

@TenzDelek

@TenzDelek TenzDelek commented Sep 17, 2026 •

Copy link
Copy Markdown
Member

fixes #779

  • hide header when scroll
  • hide video when user is joining inperson. (show the static image)
  • when Commentaries tab is open and hide video and when close again show video

Screenshots

Screenshot 2026-09-17 at 3 33 26 PM Screenshot 2026-09-17 at 3 34 06 PM

@TenzDelek
TenzDelek marked this pull request as ready for review September 17, 2026 10:04
@greptile-apps

greptile-apps Bot commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge with no outstanding blocking or non-blocking findings.

Summary

This PR adds attendance-mode handling for group events and adjusts event-plan presentation based on whether users attend online or in person.

  • Adds online/in-person participation selection and API persistence for hybrid events.
  • Shows a static event cover instead of the live stream for in-person attendees.
  • Switches live video to audio while commentary or translation panels are open.
  • Adds collapsible headers driven by reader scroll state.
  • Adds model, datasource, dialog, and live-event widget coverage.
Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Open group event] --> B{Hybrid event?}
    B -->|Yes| C[Choose online or in person]
    B -->|No| D[Infer attendance mode]
    C --> E[Persist participation type]
    D --> F[Open event plan]
    E --> F
    F --> G{Online attendee?}
    G -->|Yes| H[Show live media header]
    G -->|No| I[Show static cover]
    H --> J{Commentary or translation open?}
    J -->|Yes| K[Use audio-only mode]
    J -->|No| L[Use selected media mode]
Loading

Reviews (3) · Last reviewed commit: "Dispose CurvedAnimation in SlideAwayHead..."

@TenzDelek
TenzDelek requested a review from tentamdin September 17, 2026 10:19
The curve animation was never disposed, leaking on every reader and live
plan-details screen that mounts the header.
@tentamdin
tentamdin merged commit 905b936 into develop Sep 17, 2026
1 of 2 checks passed
@TenzDelek
TenzDelek deleted the new-changes-tara branch September 18, 2026 01:15
@tentamdin tentamdin mentioned this pull request Sep 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants