Implement foreground push filtering to suppress banners for active chatroom

[harshal-2304]

No description provided.

[greptile-apps]

Confidence Score: 5/5

The PR appears safe to merge, with the previously missing integration coverage now present.

Findings

1.  Integration coverage is missing ▶

Fix with agent prompt

### Issue 1
test/features/push_notifications/foreground_push_filter_test.dart:15-18
These tests cover the filter registry in isolation, but they do not mount `GroupChatScreen` to exercise the route, lifecycle, room-targeting, and disposal conditions that control actual suppression. A widget test for an active matching room, a covered or backgrounded screen, and claim release during disposal would prevent regressions that hide unrelated notifications or show banners for the active chat.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Summary

This PR adds foreground push filtering so notifications for the currently visible group chat do not display redundant banners.

• Introduces an app-lifetime registry of screen-owned push matchers.
• Registers and releases the group chat’s matcher with route and lifecycle guards.
• Applies filtering only to foreground local notifications.
• Adds unit and widget coverage for targeting, covered routes, lifecycle changes, and disposal.
• The previous integration-coverage finding is fully addressed by the new widget tests.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Foreground push received] --> B[PushNotificationService]
  B --> C{Message has notification?}
  C -- No --> D[Do not show banner]
  C -- Yes --> E[ForegroundPushFilter]
  E --> F{Active screen claims push?}
  F -- Yes --> D
  F -- No --> G[Show local notification]
  H[GroupChatScreen] -->|claim matcher on init| E
  H -->|release matcher on dispose| E
  H --> I{App resumed and route current?}
  I -- Yes --> J[Match room or group target]
  I -- No --> K[Do not claim push]

Loading

_{Reviews (4) · Last reviewed commit: "Add tests for foreground push filtering ..."}

[greptile-apps]

Integration coverage is missing

These tests cover the filter registry in isolation, but they do not mount GroupChatScreen to exercise the route, lifecycle, room-targeting, and disposal conditions that control actual suppression. A widget test for an active matching room, a covered or backgrounded screen, and claim release during disposal would prevent regressions that hide unrelated notifications or show banners for the active chat.

Prompt To Fix With AI

This is a comment left during a code review.
Path: test/features/push_notifications/foreground_push_filter_test.dart
Line: 15-18

Comment:
**Integration coverage is missing**

These tests cover the filter registry in isolation, but they do not mount `GroupChatScreen` to exercise the route, lifecycle, room-targeting, and disposal conditions that control actual suppression. A widget test for an active matching room, a covered or backgrounded screen, and claim release during disposal would prevent regressions that hide unrelated notifications or show banners for the active chat.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!