feat(group_profile): add group notification toggles and leave sheet - #735
Merged
Merged
Conversation
tentamdin
commented
Sep 8, 2026
Member
- Joined button opens a sheet with per-group chat and content push toggles and a confirmed Leave group action.
- Master switch off now unregisters the push device and greys out the toggles.
- Route EVENT_REMINDER pushes to the event, and skip the foreground banner for the open chat room.
Joined button opens a sheet with per-group chat and content push toggles and a confirmed Leave group action. Master switch off now unregisters the push device and greys out the toggles. Route EVENT_REMINDER pushes to the event, and skip the foreground banner for the open chat room.
Claiming the active room from initState and dispose tripped Riverpod's lifecycle guard and red-screened the chat screen. Use a plain holder object instead; push suppression reads it the same way.
tentamdin
marked this pull request as ready for review
September 8, 2026 18:32
Contributor
|
Master switch flips during an in-flight register or unregister could leave the device registered after opt-out, or lose the id of a fresh registration. Route both through one reconcile loop that re-reads state after each pass. Track open chat rooms as a stack so popping one chat re-mutes the one under it.
A master-switch opt-out whose DELETE failed offline left the device registered until some unrelated event reconciled again. Retry failed passes with linear backoff up to five times; an explicit request cancels a pending retry.
Member
Author
|
@greptileai review |
Read and write /users/me/notification-preferences/groups/{id}. Group chat
maps to CHAT_MESSAGE; group content maps to GROUP_POST, EVENT and
ACCUMULATION together, reading on only when all are enabled and unmuted.
Turning a toggle on also lifts any snooze. The sheet now fetches on open
and shows spinners until the stored values arrive.
Member
Author
…how load errors Serialize PATCHes per toggle so the backend ends on the value shown. Release the active chat room while another page covers it. Show a retry row instead of defaults when preferences fail to load.
Adopt develop's ForegroundPushFilter for banner suppression and drop the branch's own active-room mechanism; keep the master switch, reminder routing and preference work.
…target A preference write that succeeded while a newer value was queued was skipped entirely, so a later failure reverted the switch to a stale value the backend no longer held. Record every confirmed value before checking for a queued write.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.