Enhance TaskForm and related components to support linked content typ… - #289
Merged
Merged
Conversation
…es. Add tests for linked subtasks, including event and post types. Update ContentTypeSelector to handle new linked content options and ensure proper rendering in TaskView and SubTaskCard.
…y. Adjust formatting in TaskForm, ContentTypeSelector, and LinkedContent components, ensuring better alignment and clarity in code structure.
Contributor
|
Comment on lines
+103
to
+105
| ...(isLinkedSubTask(subTask) && { | ||
| reference_id: subTask.reference_id || null, | ||
| }), |
Contributor
There was a problem hiding this comment.
The create and update payloads now send reference_id, but SubTaskPayload does not declare this field. This leaves the API type out of sync with the data being sent, so future typed payload construction or refactoring could silently drop linked references. Add reference_id?: string | null to the payload type and cover the create path as well as the update path.
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/components/routes/task/components/view/TaskForm.tsx
Line: 103-105
Comment:
**Payload Type Omits Reference**
The create and update payloads now send `reference_id`, but `SubTaskPayload` does not declare this field. This leaves the API type out of sync with the data being sent, so future typed payload construction or refactoring could silently drop linked references. Add `reference_id?: string | null` to the payload type and cover the create path as well as the update path.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.…inked content types. Refactor subtask payload construction for improved clarity and maintainability. Update linked content fetcher to only retrieve published posts, ensuring better user experience.
Tech-lo
approved these changes
Sep 11, 2026
…te display. Replace date formatting functions with a new schedule formatting utility. Update event recurrence handling and enhance test coverage for event recurrence logic.
…ating import statements. This change enhances code clarity without altering functionality.
… types and chat room states. Add conditional rendering for prayer requests and improve room name display logic. Update API and schema to include chat-related fields for better event management.
tenkus47
deleted the
add-group-accumulation-and-collection-in-subtask
branch
September 11, 2026 12:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…es. Add tests for linked subtasks, including event and post types. Update ContentTypeSelector to handle new linked content options and ensure proper rendering in TaskView and SubTaskCard.