fix poem image

[Tech-lo]

Webuddhist-tech/WeBuddhist-app#741

[greptile-apps]

Confidence Score: 3/5

The PR is not yet safe to merge because explicit poem IDs can bind previews to the wrong shared resource, and transient fallback images remain cached after recovery.

Findings

1.  Poem ID overrides shared resource ▶
2.  Fallback image remains cached ▶

Fix with agent prompt

### Issue 1
pecha_api/share/share_service.py:181-182
When a share request supplies a `poem_id` that differs from the poem in its URL or accompanies a segment/text URL, this branch preserves that ID, skips segment/text image generation, and builds the preview from the supplied poem, causing crawlers to display an image that does not represent the shared resource.

### Issue 2
pecha_api/share/share_service.py:undefined-124
When a poem image is temporarily unavailable, the neutral fallback receives the same 24-hour public cache policy as a successful image, causing caches and crawlers to keep showing the fallback after the poem image becomes available again.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Summary

• Extracts poem IDs from shared URLs and resolves published poem metadata.
• Handles GET and HEAD image requests with fixed-length responses.
• Moves synchronous poem lookups into worker threads.
• Adds coverage for image conversion, fallback behavior, routing, and metadata generation.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[POST share request] --> B{poem_id supplied?}
  B -- No --> C[Extract poem ID from URL]
  B -- Yes --> D[Keep supplied poem ID]
  C --> E{Poem ID present?}
  D --> E
  E -- No --> F[Generate segment or text image]
  E -- Yes --> G[Resolve poem title]
  G --> H[Create poem image URL]
  H --> I[GET or HEAD share/image]
  I --> J{Published image available and decodable?}
  J -- Yes --> K[Normalize to 1200x630 JPEG]
  J -- No --> L[Generate neutral in-memory PNG]

Loading

_{Reviews (14) · Last reviewed commit: "image size fix"}

[greptile-apps]

Fallback image remains cached

When a poem image is temporarily unavailable, the neutral fallback receives the same 24-hour public cache policy as a successful image, causing caches and crawlers to keep showing the fallback after the poem image becomes available again.

Prompt To Fix With AI

This is a comment left during a code review.
Path: pecha_api/share/share_service.py
Line: 108

Comment:
**Fallback image remains cached**

When a poem image is temporarily unavailable, the neutral fallback receives the same 24-hour public cache policy as a successful image, causing caches and crawlers to keep showing the fallback after the poem image becomes available again.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

[greptile-apps]

Poem ID overrides shared resource

When a share request supplies a poem_id that differs from the poem in its URL or accompanies a segment/text URL, this branch preserves that ID, skips segment/text image generation, and builds the preview from the supplied poem, causing crawlers to display an image that does not represent the shared resource.

Prompt To Fix With AI

This is a comment left during a code review.
Path: pecha_api/share/share_service.py
Line: 181-182

Comment:
**Poem ID overrides shared resource**

When a share request supplies a `poem_id` that differs from the poem in its URL or accompanies a segment/text URL, this branch preserves that ID, skips segment/text image generation, and builds the preview from the supplied poem, causing crawlers to display an image that does not represent the shared resource.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
93.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud