Skip to content

adding granularity#11

Merged
MikeLippincott merged 3 commits intoWayScience:mainfrom
MikeLippincott:granularity
May 7, 2026
Merged

adding granularity#11
MikeLippincott merged 3 commits intoWayScience:mainfrom
MikeLippincott:granularity

Conversation

@MikeLippincott
Copy link
Copy Markdown
Member

Description

This PR adds granularity modules. Note that this might fail tests due to not having a key piece of image-loading code that is in another PR.

What kind of change(s) are included?

  • Documentation (changes docs or other related content)
  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (these changes would cause existing functionality to not work as expected).

Checklist

Please ensure that all boxes are checked before indicating that this pull request is ready for review.

  • I have read and followed the CONTRIBUTING.md guidelines.
  • I have searched for existing content to ensure this is not a duplicate.
  • I have performed a self-review of these additions (including spelling, grammar, and related).
  • These changes pass all pre-commit checks.
  • I have added comments to my code to help provide understanding
  • I have added a test which covers the code changes found within this PR
  • I have deleted all non-relevant text in this pull request template.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@MattsonCam
Copy link
Copy Markdown
Member

Are any of these test for granualrity? I'm not seeing any passing test, so if there is a granularity test it either isn't running or it failed

Copy link
Copy Markdown
Member

@MattsonCam MattsonCam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @MikeLippincott , good job! I left a few comments

Comment thread src/zedprofiler/featurization/granularity.py
Comment thread src/zedprofiler/featurization/granularity.py
Comment thread src/zedprofiler/featurization/granularity.py
Comment thread src/zedprofiler/featurization/granularity.py
Comment thread tests/featurization/test_granularity.py Outdated
Comment thread src/zedprofiler/featurization/granularity.py
@MikeLippincott MikeLippincott merged commit b70fafb into WayScience:main May 7, 2026
0 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants