fix(integration-tests): use spawnSync to capture stdout+stderr (CI fix)#411
Merged
Merged
Conversation
The execSync(cmd 2>&1) approach didn't work in GitHub Actions runners — gh --help still produced empty output even with stderr merged. Switch to spawnSync which gives separate stdout/stderr buffers we can concatenate. Also unset PAGER vars to defeat any pager-detection short-circuiting (some gh versions check terminal capabilities and suppress --help output if pagination is unavailable). This is a follow-up to the prior captureHelp commit on this branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to PR #410. The
execSync(cmd 2>&1)approach didn't work in GitHub Actions runners —gh --helpstill produced empty output even with stderr merged. Switching tospawnSyncwhich gives separate stdout/stderr buffers we can concatenate.Also unsets pager environment variables (
GH_PAGER,PAGER,GLAB_PAGER) to defeat any pager-detection short-circuiting — someghversions check terminal capabilities and suppress--helpoutput if pagination is unavailable.Changes
tests/integration/cli-flag-shapes.test.ts:captureHelp()now usesspawnSyncinstead ofexecSyncresult.stdout + result.stderrTests
Why this matters
PR #410's first attempt didn't work because shell-level
2>&1doesn't capture output thatghwrites via TTY-aware paths.spawnSyncbypasses the shell entirely and captures the actual file descriptors.