chore(ci): add chore/* and docs/* to ci.yml push trigger#20
Merged
Conversation
The CI workflow's push trigger only fired on main, feature/*, and fix/* branches. chore/* and docs/* branches were silently skipped on push, relying entirely on the pull_request trigger to provide CI feedback. This created an asymmetry: feature/fix branches got immediate CI on every push, but chore/docs branches had to wait for a PR to open. CLAUDE.md "Branching Strategy" lists all four types as first-class, so the CI trigger should match. Add chore/* and docs/* to the push trigger branches array. Pure additive change — no procedural logic introduced, no existing patterns removed, complies with the new MANDATORY: No Procedural Logic in CI/CD YAML rule. Surfaced during PR #18 (chore/17-ccfold-template-merge) when `gh pr checks --watch` initially reported "no checks reported" until the pull_request event picked up the slack a moment later. The fix is self-validating: pushing this chore/* branch with the new trigger in place either fires CI on the push event (success) or doesn't (the pull_request fallback still covers the merge gate). Closes #19 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
chore/*anddocs/*to the.github/workflows/ci.ymlpush trigger branches array. Brings CI feedback parity to all four branch types defined in CLAUDE.md's "Branching Strategy" (feature,fix,chore,docs). Single-line additive change.Surfaced during PR #18 (chore/17-ccfold) when
gh pr checks --watchinitially reported "no checks reported" until the pull_request event picked up the slack. Pre-fix behavior: chore/docs pushes were silently skipped on the push event. Post-fix: same fast-feedback loop as feature/fix branches.Changes
.github/workflows/ci.yml(single line, +1/-1) — push trigger branches array goes from["main", "feature/*", "fix/*"]to["main", "feature/*", "fix/*", "chore/*", "docs/*"]. Existing patterns preserved, two new globs appended. No procedural logic added — complies with the new MANDATORY: No Procedural Logic in CI/CD YAML rule from chore(meta): fold CLAUDE.md template + bootstrap .claude-project.md #17.Linked Issues
Closes #19
Test Plan
bun test— 111 pass / 0 fail / 330 expect() calls (unchanged from baseline; no code touched)scripts/ci/validate.sh— full validation green (TypeScript + shellcheck + tests)feature-dev:code-reviewerover the YAML change — reports "no issues found at medium risk or above", change is "correct, complete, and safe to merge"chore/*branch with the fix in place,gh run list --branch chore/19-ci-branch-trigger-gapshowed apushevent CI run queued immediately. GitHub Actions evaluates workflow files from the branch being pushed, so the fix took effect on this very branch before merge. Compare to PR chore(meta): fold CLAUDE.md template + bootstrap .claude-project.md #18's pre-fix behavior, where the same query returned "no checks reported" until the pull_request event firedrelease.ymlhas no equivalent gap (it's tag-triggered only)merge_group:trigger is unaffected — it uses GitHub's queue machinery independently ofpush.branchesmatchingpull_requesttrigger or required-status-checksNotes
origin/feature/*remote-tracking refs (10 of them) are a separate housekeeping item I flagged earlier — say the word and I'll prune them.