feat: expose second fan RPM (fan2rpm) via API and UI#6
Open
nathanmarlor wants to merge 3 commits into
Open
Conversation
fan_rpm[1] was already being populated in power_management_task.c via PAC9544 channel mux. Expose it in the GET response and display Fan 2 Speed in the temperature card when non-zero.
Show both fan RPMs on a single line when a second fan is present: 100% (1: 1200 RPM) (2: 1100 RPM)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fan2rpmfield to the system info API response (second fan RPM fromfan_rpm[1])Test plan
fan2rpmfield