fix: load InternalAuth allowlist from env instead of hardcoding - #1169
Merged
harshhsahu merged 1 commit intoAug 24, 2026
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
PR review rate limit exceeded |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
InternalAuth previously allowed only a hardcoded list of emails in source. That exposed privileged emails in the repo and made updates require a code change.
This change reads the allowlist from INTERNAL_ALLOWED_EMAILS (comma-separated) at startup into a Set, so:
emails stay out of source control
no DB call is needed
allowlist can be updated via env/secrets without redeploying code changes for the list itself
Also documents the variable in .env.example.