Conversation
…be set in item_aliases.csv when required. Also makes the default kit valid now (excluding an issue with damage values).
WizardCM
requested changes
Oct 12, 2025
Member
WizardCM
left a comment
WizardCM
left a comment
There was a problem hiding this comment.
Once changes are made, please squash commits and keep the commit title short, with any elaboration in the description.
| */ | ||
| package org.royaldev.royalcommands; | ||
|
|
||
| import org.apache.commons.lang3.ArrayUtils; |
| for (final ConfigurationNode item : items) { | ||
| final ItemStack is = this.getItemStack(item); | ||
| if (is == null) continue; | ||
| if (is == null) { |
Member
There was a problem hiding this comment.
While I agree this change is probably something we want to move towards, this shouldn't be done as part of this PR and should be part of a bigger code cleanup commit that can then be ignored using Git's ignore refs.
Comment on lines
+73
to
74
| final Damageable imd = (Damageable) is.getItemMeta(); | ||
| imd.setDamage(item.getShort("damage", (short) 0)); |
Member
There was a problem hiding this comment.
These two lines could probably be removed, as it's just setting damage to 0, which is the default, and then never actually updating the is meta.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made item aliases an optional feature, item aliases can now be set in item_aliases.csv when required. Also makes the default kit valid now (excluding an issue with damage values).