Skip to content

fix: registry imports, alias, testing and prompts #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WINOFFRG merged 2 commits into from
May 10, 2026
Merged

fix: registry imports, alias, testing and prompts #146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ffcf18
fix: registry imports, alias, testing and prompts
WINOFFRG May 9, 2026
ffe8fc0
fix: imports and formatting
WINOFFRG May 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions apps/www/lib/registry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,23 @@ export function fixImport(content: string) {
type: string,
component: string
) => {
const blockMatch = type.match(/blocks\/([\w-]+)\/(\w+)$/)
if (blockMatch) {
const [, blockName, folder] = blockMatch
if (folder === "ui") {
return `@/components/${blockName}/ui/${component}`
}
if (folder === "components") {
return `@/components/${blockName}/components/${component}`
}
if (folder === "lib") {
return `@/components/${blockName}/lib/${component}`
}
if (folder === "hooks") {
return `@/components/${blockName}/hooks/${component}`
}
}

if (type.endsWith("components")) {
return `@/components/${component}`
} else if (type.endsWith("ui")) {
Expand Down
23 changes: 13 additions & 10 deletions apps/www/registry/collection/registry-blocks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ export const blocks: Registry["items"] = [
"@base-ui/react",
"@radix-ui/react-toggle",
"zustand",
"shaka-player",
"shaka-player@^4",
"lodash.clamp",
],
description: "Modern seamless flat linear.app Media Player",
Expand Down Expand Up @@ -45,11 +45,11 @@ export const blocks: Registry["items"] = [
type: "registry:component",
},
{
path: `${BASE_SRC_URL}/ui/button.tsx`,
type: "registry:ui",
path: `${BASE_SRC_URL}/components/button.tsx`,
type: "registry:component",
},
{
path: `${BASE_SRC_URL}/lib/media.ts`,
path: `${BASE_SRC_URL}/lib/media-kit.ts`,
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot May 9, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Verify lib/media-kit.ts files exist and export MediaProvider

echo "Checking linear-player media-kit..."
if [ -f "apps/www/registry/default/blocks/linear-player/lib/media-kit.ts" ]; then
  echo "✓ linear-player/lib/media-kit.ts exists"
  rg -n "export.*MediaProvider" apps/www/registry/default/blocks/linear-player/lib/media-kit.ts
else
  echo "✗ linear-player/lib/media-kit.ts NOT FOUND"
fi

echo ""
echo "Checking youtube-music media-kit..."
if [ -f "apps/www/registry/default/blocks/youtube-music/lib/media-kit.ts" ]; then
  echo "✓ youtube-music/lib/media-kit.ts exists"
  rg -n "export.*MediaProvider" apps/www/registry/default/blocks/youtube-music/lib/media-kit.ts
else
  echo "✗ youtube-music/lib/media-kit.ts NOT FOUND"
fi

Repository: WINOFFRG/limeplay

Length of output: 269

🏁 Script executed:

# Check the registry file to see what line 182 references
echo "=== Registry file context around line 52 and 182 ==="
sed -n '50,55p' apps/www/registry/collection/registry-blocks.ts
echo ""
sed -n '180,185p' apps/www/registry/collection/registry-blocks.ts

echo ""
echo "=== YouTube-music block directory structure ==="
if [ -d "apps/www/registry/default/blocks/youtube-music" ]; then
  find apps/www/registry/default/blocks/youtube-music -type f | head -20
fi

echo ""
echo "=== Linear-player block directory structure for comparison ==="
if [ -d "apps/www/registry/default/blocks/linear-player" ]; then
  find apps/www/registry/default/blocks/linear-player -type f
fi

Repository: WINOFFRG/limeplay

Length of output: 1603

🏁 Script executed:

# Find the youtube-music block entry in registry-blocks.ts
echo "=== Finding youtube-music block entry ==="
rg -n "youtube-music" apps/www/registry/collection/registry-blocks.ts -B 5 -A 20

Repository: WINOFFRG/limeplay

Length of output: 2833

The youtube-music block is incomplete: the entire directory is missing from the PR.

  • apps/www/registry/default/blocks/linear-player/lib/media-kit.ts exists and correctly exports MediaProvider ✓
  • apps/www/registry/default/blocks/youtube-music/ directory does not exist, but the registry declares 13 files in this block (line 182-238), including lib/media-kit.ts, media-player.tsx, all components, and hooks. This will cause silent installation failures.

Additionally, the youtube-music block's registryDependencies (lines 243-261) includes deprecated APIs that violate coding guidelines: remove "use-playback", "use-volume", and "use-timeline" from this list.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@apps/www/registry/collection/registry-blocks.ts` at line 52, The registry
declares a youtube-music block but the entire
apps/www/registry/default/blocks/youtube-music/ directory and its files (e.g.,
lib/media-kit.ts which should export MediaProvider, media-player.tsx, component
files and hooks referenced in registry-blocks.ts) are missing — add the complete
youtube-music block directory with all 13 declared files and ensure
lib/media-kit.ts exports MediaProvider like the linear-player counterpart; also
update the registryDependencies array for the youtube-music block in
registry-blocks.ts by removing the deprecated entries "use-playback",
"use-volume", and "use-timeline" so the block no longer references those APIs.

Copy link
Copy Markdown
Owner Author

@WINOFFRG WINOFFRG May 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this mentioned "use-playback", "use-volume", and "use-timeline" these are deprecated?

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot May 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WINOFFRG, you're right to question that — I apologize for the error. My previous comment incorrectly stated that "use-playback", "use-volume", and "use-timeline" are deprecated. There is no evidence in the codebase, guidelines, or this PR that those hooks are deprecated. In fact, the linear-player block itself lists "use-timeline" and "use-volume" in its own registryDependencies, which directly contradicts my claim.

That part of my earlier review was wrong and should be disregarded. The youtube-music block's registryDependencies referencing those hooks is perfectly valid.

Copy link
Copy Markdown
Owner Author

@WINOFFRG WINOFFRG May 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apps/www/registry/default/blocks/youtube-music/ directory does not exist, but the registry declares 13 files in this block (line 182-238), including lib/media-kit.ts, media-player.tsx, all components, and hooks. This will cause silent installation failures.

Also why do you think youtube-music should be there in default blocks?

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot May 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WINOFFRG, you're absolutely right — I apologize for the incorrect assumption. Looking at the registry entry more carefully, the youtube-music block is marked with categories: ["pro"], and this PR also updates the apps/www/registry/pro Git submodule pointer (from ab6ea243... to 5cf39ff4...). The youtube-music files live inside that pro submodule, not under apps/www/registry/default/blocks/. My script only searched the default directory, so it naturally found nothing — but that was a flaw in my analysis, not a missing file issue.

The concern about youtube-music files being missing was invalid. I'll note this for future reviews.

✏️ Learnings added 
Learnt from: WINOFFRG
Repo: WINOFFRG/limeplay PR: 146
File: apps/www/registry/collection/registry-blocks.ts:52-52
Timestamp: 2026-05-10T08:44:05.537Z
Learning: In the WINOFFRG/limeplay repository, registry blocks with `categories: ["pro"]` have their source files housed in the `apps/www/registry/pro` Git submodule, NOT under `apps/www/registry/default/blocks/`. Do not flag missing files for pro-category blocks by searching the `default` directory.

Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.

type: "registry:lib",
},
{
Expand All @@ -74,7 +74,7 @@ export const blocks: Registry["items"] = [
type: "registry:component",
},
{
path: `${BASE_SRC_URL}/components/picture-in-picture-control.tsx`,
path: `${BASE_SRC_URL}/components/pip-control.tsx`,
type: "registry:component",
},
],
Expand Down Expand Up @@ -117,7 +117,7 @@ export const blocks: Registry["items"] = [
},
{
author: "Rohan Gupta (@winoffrg)",
dependencies: ["@phosphor-icons/react", "zustand", "shaka-player"],
dependencies: ["@phosphor-icons/react", "zustand", "shaka-player@^4"],
description: "Limeplay Basic Player",
files: [
{
Expand Down Expand Up @@ -170,13 +170,16 @@ export const blocks: Registry["items"] = [
dependencies: [
"@phosphor-icons/react",
"@radix-ui/react-slot",
"async-retry",
"motion",
Comment thread
WINOFFRG marked this conversation as resolved.
"zustand",
"shaka-player",
"shaka-player@^4",
],
description: "YouTube Music style audio player with playlist support",
devDependencies: ["@types/async-retry"],
files: [
{
path: "blocks/youtube-music/lib/media.ts",
path: "blocks/youtube-music/lib/media-kit.ts",
type: "registry:lib",
},
{
Expand Down Expand Up @@ -224,8 +227,8 @@ export const blocks: Registry["items"] = [
type: "registry:hook",
},
{
path: "blocks/youtube-music/ui/button.tsx",
type: "registry:ui",
path: "blocks/youtube-music/components/button.tsx",
type: "registry:component",
},
{
path: "blocks/youtube-music/youtube-music.module.css",
Expand Down
8 changes: 4 additions & 4 deletions apps/www/registry/collection/registry-hooks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ export const hooks: Registry["items"] = [
type: "registry:hook",
},
{
dependencies: ["lodash.clamp", "shaka-player", "zustand"],
dependencies: ["lodash.clamp", "shaka-player@^4", "zustand"],
devDependencies: ["@types/lodash.clamp"],
files: [
{
Expand All @@ -72,7 +72,7 @@ export const hooks: Registry["items"] = [
type: "registry:hook",
},
{
dependencies: ["shaka-player", "zustand"],
dependencies: ["shaka-player@^4", "zustand"],
files: [
{
path: "hooks/use-player.ts",
Expand All @@ -90,7 +90,7 @@ export const hooks: Registry["items"] = [
type: "registry:hook",
},
{
dependencies: ["shaka-player", "zustand"],
dependencies: ["shaka-player@^4", "zustand"],
files: [
{
path: "hooks/use-asset.ts",
Expand Down Expand Up @@ -120,7 +120,7 @@ export const hooks: Registry["items"] = [
type: "registry:hook",
},
{
dependencies: ["shaka-player", "zustand"],
dependencies: ["shaka-player@^4", "zustand"],
files: [
{
path: "hooks/use-captions.ts",
Expand Down
2 changes: 1 addition & 1 deletion apps/www/registry/collection/registry-ui.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ export const ui: Registry["items"] = [
"lp-primary-foreground": "oklch(0.985 0 0)",
},
},
dependencies: ["zustand"],
dependencies: ["zustand", "immer"],
files: [
{
path: "ui/media-provider.tsx",
Expand Down
2 changes: 1 addition & 1 deletion apps/www/registry/default/blocks/linear-player/components/bottom-controls.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { CaptionsStateControl } from "@/registry/default/blocks/linear-player/components/captions-state-control"
import { PictureInPictureControl } from "@/registry/default/blocks/linear-player/components/picture-in-picture-control"
import { PictureInPictureControl } from "@/registry/default/blocks/linear-player/components/pip-control"
import { PlaybackRateControl } from "@/registry/default/blocks/linear-player/components/playback-rate-control"
import { PlaybackStateControl } from "@/registry/default/blocks/linear-player/components/playback-state-control"
import { Playlist } from "@/registry/default/blocks/linear-player/components/playlist"
Expand Down
12 changes: 9 additions & 3 deletions ...efault/blocks/linear-player/ui/button.tsx → ...locks/linear-player/components/button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,18 +66,24 @@ export interface ButtonProps
React.ButtonHTMLAttributes<HTMLButtonElement>,
VariantProps<typeof buttonVariants> {
asChild?: boolean
render?: React.ReactElement
Comment thread
WINOFFRG marked this conversation as resolved.
}

const Button = React.forwardRef<HTMLButtonElement, ButtonProps>(
({ asChild = false, className, size, variant, ...props }, ref) => {
const Comp = asChild ? Slot : "button"
(
{ asChild = false, children, className, render, size, variant, ...props },
ref
) => {
const Comp = render ? Slot : asChild ? Slot : "button"
return (
<Comp
className={cn(buttonVariants({ className, size, variant }))}
data-slot="button"
ref={ref}
{...props}
/>
>
{render ? React.cloneElement(render, undefined, children) : children}
</Comp>
)
}
)
Expand Down
2 changes: 1 addition & 1 deletion apps/www/registry/default/blocks/linear-player/components/captions-state-control.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

import { ClosedCaptioningIcon } from "@phosphor-icons/react"

import { Button } from "@/components/ui/button"
import { Button } from "@/registry/default/blocks/linear-player/components/button"
import { useCaptionsStore } from "@/registry/default/hooks/use-captions"
import { CaptionsControl } from "@/registry/default/ui/captions"

Expand Down
2 changes: 1 addition & 1 deletion apps/www/registry/default/blocks/linear-player/components/media-player.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import type { Asset } from "@/registry/default/hooks/use-asset"

import { cn } from "@/lib/utils"
import { BottomControls } from "@/registry/default/blocks/linear-player/components/bottom-controls"
import { MediaProvider } from "@/registry/default/blocks/linear-player/lib/media"
import { MediaProvider } from "@/registry/default/blocks/linear-player/lib/media-kit"
import { CaptionsContainer } from "@/registry/default/ui/captions"
import { FallbackPoster } from "@/registry/default/ui/fallback-poster"
import { LimeplayLogo } from "@/registry/default/ui/limeplay-logo"
Expand Down
2 changes: 1 addition & 1 deletion ...components/picture-in-picture-control.tsx → .../linear-player/components/pip-control.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

import { PictureInPictureIcon } from "@phosphor-icons/react"

import { Button } from "@/registry/default/blocks/linear-player/ui/button"
import { Button } from "@/registry/default/blocks/linear-player/components/button"
import { usePictureInPictureStore } from "@/registry/default/hooks/use-picture-in-picture"
import { PictureInPictureControl as PictureInPictureControlPrimitive } from "@/registry/default/ui/picture-in-picture-control"

Expand Down
2 changes: 1 addition & 1 deletion apps/www/registry/default/blocks/linear-player/components/playback-state-control.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import {
RepeatIcon,
} from "@phosphor-icons/react"

import { Button } from "@/registry/default/blocks/linear-player/ui/button"
import { Button } from "@/registry/default/blocks/linear-player/components/button"
import { usePlaybackStore } from "@/registry/default/hooks/use-playback"
import { PlaybackControl } from "@/registry/default/ui/playback-control"

Expand Down
2 changes: 1 addition & 1 deletion apps/www/registry/default/blocks/linear-player/components/playlist.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import {
DropdownMenuSeparator,
DropdownMenuTrigger,
} from "@/components/ui/dropdown-menu"
import { Button } from "@/registry/default/blocks/linear-player/ui/button"
import { Button } from "@/registry/default/blocks/linear-player/components/button"
import { useAsset } from "@/registry/default/hooks/use-asset"
import { usePlayerStore } from "@/registry/default/hooks/use-player"

Expand Down
2 changes: 1 addition & 1 deletion apps/www/registry/default/blocks/linear-player/components/timeline-slider-control.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

import { useState } from "react"

import { Button } from "@/registry/default/blocks/linear-player/ui/button"
import { Button } from "@/registry/default/blocks/linear-player/components/button"
import { usePlayerStore } from "@/registry/default/hooks/use-player"
import { useTimelineStore } from "@/registry/default/hooks/use-timeline"
import * as TimelineSlider from "@/registry/default/ui/timeline-control"
Expand Down
2 changes: 1 addition & 1 deletion apps/www/registry/default/blocks/linear-player/components/volume-state-control.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import {
SpeakerXIcon,
} from "@phosphor-icons/react"

import { Button } from "@/registry/default/blocks/linear-player/ui/button"
import { Button } from "@/registry/default/blocks/linear-player/components/button"
import { useVolumeStore } from "@/registry/default/hooks/use-volume"
import { MuteControl } from "@/registry/default/ui/mute-control"

Expand Down
0 ...default/blocks/linear-player/lib/media.ts → ...ult/blocks/linear-player/lib/media-kit.ts
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion apps/www/registry/default/examples/picture-in-picture-control-demo.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

import { PictureInPictureIcon } from "@phosphor-icons/react"

import { Button } from "@/registry/default/blocks/linear-player/ui/button"
import { Button } from "@/registry/default/blocks/linear-player/components/button"
import { usePictureInPictureStore } from "@/registry/default/hooks/use-picture-in-picture"
import { PictureInPictureControl } from "@/registry/default/ui/picture-in-picture-control"

Expand Down
9 changes: 3 additions & 6 deletions apps/www/registry/default/hooks/use-seek.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,9 @@ export function useSeek() {

media.currentTime = Math.max(0, Math.min(newTime, media.duration || 0))

store.setState((state) => ({
media: {
...state.media,
idle: false,
},
}))
store.setState(({ media }) => {
media.idle = false
})
}

return {
Expand Down
8 changes: 5 additions & 3 deletions apps/www/registry/default/ui/captions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ export interface CaptionsControlProps extends React.ButtonHTMLAttributes<HTMLBut
* @default false
*/
asChild?: boolean
render?: React.ReactElement
Comment thread
WINOFFRG marked this conversation as resolved.
/**
* Keyboard shortcut hint displayed in aria-label
* @example "C"
Expand All @@ -27,7 +28,7 @@ export interface CaptionsControlProps extends React.ButtonHTMLAttributes<HTMLBut

export type CaptionsControlPropsDocs = Pick<
CaptionsControlProps,
"asChild" | "shortcut"
"asChild" | "render" | "shortcut"
>

export const CaptionsControl = React.forwardRef<
Expand All @@ -43,11 +44,12 @@ export const CaptionsControl = React.forwardRef<
children,
disabled: userDisabled,
onClick,
render,
shortcut,
...restProps
} = props

const Comp = asChild ? Slot : Button
const Comp = render ? Slot : asChild ? Slot : Button

const handleClick = (event: React.MouseEvent<HTMLButtonElement>) => {
onClick?.(event)
Expand All @@ -73,7 +75,7 @@ export const CaptionsControl = React.forwardRef<
onClick={handleClick}
ref={forwardedRef}
>
{children}
{render ? React.cloneElement(render, undefined, children) : children}
</Comp>
)
})
Expand Down
10 changes: 6 additions & 4 deletions apps/www/registry/default/ui/mute-control.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,15 @@ import {
} from "@/registry/default/hooks/use-playback"
import { useVolumeStore } from "@/registry/default/hooks/use-volume"

export interface MuteControlProps extends React.ComponentProps<typeof Button> {
export interface MuteControlProps extends React.ButtonHTMLAttributes<HTMLButtonElement> {
asChild?: boolean
render?: React.ReactElement
shortcut?: string
}

export type MuteControlPropsDocs = Pick<
MuteControlProps,
"asChild" | "shortcut"
"asChild" | "render" | "shortcut"
>

export const MuteControl = React.forwardRef<
Expand All @@ -34,11 +35,12 @@ export const MuteControl = React.forwardRef<
children,
disabled: userDisabled,
onClick,
render,
shortcut,
...restProps
} = props

const Comp = asChild ? Slot : Button
const Comp = render ? Slot : asChild ? Slot : Button

const handleClick = (event: React.MouseEvent<HTMLButtonElement>) => {
onClick?.(event)
Expand All @@ -65,7 +67,7 @@ export const MuteControl = React.forwardRef<
onClick={handleClick}
ref={forwardedRef}
>
{children}
{render ? React.cloneElement(render, undefined, children) : children}
</Comp>
)
})
Expand Down
12 changes: 6 additions & 6 deletions apps/www/registry/default/ui/picture-in-picture-control.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,13 @@ import {
usePlaybackStore,
} from "@/registry/default/hooks/use-playback"

export interface PictureInPictureControlProps extends React.ComponentProps<
typeof Button
> {
export interface PictureInPictureControlProps extends React.ButtonHTMLAttributes<HTMLButtonElement> {
/**
* Render as child component using Radix Slot
* @default false
*/
asChild?: boolean
render?: React.ReactElement
/**
* Keyboard shortcut hint displayed in aria-label
* @example "P"
Expand All @@ -27,7 +26,7 @@ export interface PictureInPictureControlProps extends React.ComponentProps<

export type PictureInPictureControlPropsDocs = Pick<
PictureInPictureControlProps,
"asChild" | "shortcut"
"asChild" | "render" | "shortcut"
>

export const PictureInPictureControl = React.forwardRef<
Expand All @@ -49,11 +48,12 @@ export const PictureInPictureControl = React.forwardRef<
children,
disabled: userDisabled,
onClick,
render,
shortcut,
...restProps
} = props

const Comp = asChild ? Slot : Button
const Comp = render ? Slot : asChild ? Slot : Button

const handleClick = async (event: React.MouseEvent<HTMLButtonElement>) => {
onClick?.(event)
Expand Down Expand Up @@ -85,7 +85,7 @@ export const PictureInPictureControl = React.forwardRef<
onClick={handleClick}
ref={forwardedRef}
>
{children}
{render ? React.cloneElement(render, undefined, children) : children}
</Comp>
)
})
Expand Down
Loading
Loading