feat(settlement-workflow): implement on-chain compliance-gated execution workflow - #335
Merged
misrasamuelisiguzor-oss merged 2 commits intoJul 27, 2026
Conversation
…ion workflow Closes WHEELBACK#82
|
@Markadrian6399 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
contracts/settlement-workflow/crate implementing theSettlementWorkflowrole documented inARCHITECTURE.md's sequence diagram: gatesTreasury::execute_settlementbehindCompliance::is_allowed, since Treasury does not consult compliance itself.compliance-clientfor the compliance check andtreasury's generated client directly for execution, per the issue's suggested execution.contracts/settlement-workflow/tests/settlement_workflow_test.rscovering: execution blocked when compliance returnsfalse(WorkflowError::ComplianceFailed, no token transfer), and the successful path executing the treasury settlement and transferring tokens to the merchant.Cargo.toml.Closes #274
Validation performed
cargo fmt -p comebackhere-settlement-workflowpasses.cargo test --allcould not be run: the pre-existingcomebackhere-treasury/comebackhere-invoicecrates fail to compile in this environment withTreasuryContractArgs/TreasuryContractClientnot found errors. This reproduces identically on a cleanmaincheckout with zero changes applied (unrelated to this change, not addressed here per scope). The new contract's logic mirrors the already-testedexecute_with_compliancereference implementation incontracts/treasury/tests/compliance_gate_integration_test.rs, calling the same client methods with the same signatures.