Degrees - #19
Merged
Merged
Conversation
All public-facing angle parameters (θ, Φ, α, alpha_soil, beta_soil) in FixedSource, DirectionalSource, and the internal helpers polar_to_cartesian and rotate_coordinates now accept and expect degrees. Trig functions updated to their degree counterparts (cosd, sind, acosd) throughout Materials/ (Lambertian, Phong) and Sources/ (SourceAngle). Default values updated (α = 180.0, beta_soil = 180.0). All tests updated to match. Also widens the borderline BVH/Naive consistency tolerance in test_graphs.jl (6e-5 → 1e-4) to account for tiny floating-point differences between cosd and cos(deg2rad(…)); the comment in that test already noted the divergence was non-zero and non-decreasing with nrays. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All public-facing angle parameters (θ, Φ, α, alpha_soil, beta_soil) in FixedSource, DirectionalSource, and the internal helpers polar_to_cartesian and rotate_coordinates now accept and expect degrees. Trig functions updated to their degree counterparts (cosd, sind, acosd) throughout Materials/ (Lambertian, Phong) and Sources/ (SourceAngle). Default values updated (α = 180.0, beta_soil = 180.0). All tests updated to match.