[v4] better handling of splat kwargs and with_collection#2332
Merged
Conversation
Contributor
|
1 file(s) had their final line ending fixed:
|
joelhawksley
force-pushed
the
2020-splat-kwarg
branch
from
cc340ca to
686782b
Compare
joelhawksley
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
This PR attempts to fix #2020.
What approach did you choose and why?
I had to make some somewhat significant changes to our inheritance approach due to how
Rails.application.routes.url_helperswas adding an initializer to all ViewComponents.