Codemod v3 slots improvements#1746
Conversation
|
@Spone can we merge it at the current state? I included this class in Polaris ViewComponents v1 release and tested upgrade on a couple production apps. It works great. Even if the current implementation is not perfect it will be beneficial to have it shipped with ViewComponent now when people are doing upgrades to v3. In a couple of months this will be less useful I suppose. |
|
I agree. What do you think @joelhawksley? |
joelhawksley
left a comment
There was a problem hiding this comment.
I like the idea of getting this into main even if it isn't perfect ❤️
| gem "puma", "~> 5" | ||
|
|
||
| gem "selenium-webdriver", "~> 4" | ||
| gem "selenium-webdriver", "~> 4", "< 4.9.1" |
There was a problem hiding this comment.
Do you still need this? I'm wary of introducing such a restriction as it is something we'll have to eventually remove.
Co-authored-by: Hans Lemuet <Spone@users.noreply.github.com>
Co-authored-by: Hans Lemuet <Spone@users.noreply.github.com>
|
@joelhawksley please note that this PR is a contribution to #1669. We'll need to make a final review there once merged. |
|
Let's wrap this up in #1669! |
This PR includes improvements for #1669:
bin/rails view_component:detect_legacy_slotsbin/rails view_component:migrate_legacy_slots