test: exercise readable docs-only validation - #17
Closed
viniciusferrao wants to merge 2 commits into
Closed
Conversation
A few code blocks run a comment line directly against the previous command, while every other comment in the same block is preceded by a blank line. Add the missing blank lines for consistent rendering: - network/infiniband/head-node.md.j2 (Start up NetworkManager) - scheduler/slurm/install.md.j2 (Setup default cgroups file) - customize/memlimits.md.j2 (Update memlock settings on compute) - customize/nhc.md.j2 (execute every five minutes) Cosmetic only. Signed-off-by: Vinícius Ferrão <ferrao@versatushpc.com.br> Sponsored-by: VersatusHPC
The guides overwhelmingly use bare unit names with systemctl (32 call sites) but seven stragglers spell out .service -- sometimes inconsistently within the same file (nfs.md.j2, time.md.j2). Normalize on the bare name; systemctl appends .service by default. Cosmetic only. Signed-off-by: Vinícius Ferrão <ferrao@versatushpc.com.br> Sponsored-by: VersatusHPC
Member
Author
|
Closing this disposable CI validation PR after collecting the test results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disposable fork-only PR validating the revised docs-only routing with the exact docs/install changes from openhpc#2652. It will be closed and its branches deleted after the workflow completes.