[Fix Bug] correct multi-gpu appearance style aggregation#207
Open
z-jiaming wants to merge 1 commit into
Open
Conversation
z-jiaming
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(vbench): correct multi-gpu appearance style aggregation
The multi-GPU path for appearance_style previously gathered per-video results from all ranks, but computed the final score from each video's
cur_simfield. cur_sim only stores the last processed frame score for a video, while the single-GPU path reports the average score across all frames.This caused single-GPU and multi-GPU evaluation runs to produce different top-level appearance_style scores even when their per-video video_results were identical.
Compute the distributed aggregate from video_results instead, matching the single-GPU behavior and the values written in the detailed results.