Skip to content

Conversation

@parhamsoltani
Copy link

Interface now uses std_ulogic/std_ulogic_vector, addresses are now unsigned and UpperCamelCase is used to increase readability. Contributions on feature/wishbone are now splitted into a new PR.

@Paebbels Paebbels added Enhancement New feature or request SoC Bus Architecture labels Dec 11, 2025
@Paebbels Paebbels added this to the v1.1 milestone Dec 11, 2025
@Paebbels Paebbels linked an issue Dec 11, 2025 that may be closed by this pull request
@Paebbels Paebbels added Internal Mainly internal interface between components. Memory-Mapped labels Dec 11, 2025
Copy link
Member

@Paebbels Paebbels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the proposed names aren't matching the specification for 100% anymore, I suggest to prefer a clean naming scheme. This isn't chaning the name/meaning itself, just changing abbreviations to full non-abbreviated names.

Comment on lines +57 to +58
Wishbone/vB3/Wishbone_Generic.vhdl

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Wishbone/vB3/Wishbone_Generic.vhdl
Wishbone/vB3/Wishbone_Generic.vhdl

@Paebbels Paebbels mentioned this pull request Dec 13, 2025
34 tasks
@JimLewis
Copy link

JimLewis commented Jan 6, 2026

Why are names that differ from the Wishbone spec being used? I too do not like shortened names, however, I also cannot see using any names other than the standard names. I see there being some freedom when the interface is a split transaction interface (like AXI) and multiple layers of records are used.

@parhamsoltani
Copy link
Author

Why are names that differ from the Wishbone spec being used? I too do not like shortened names, however, I also cannot see using any names other than the standard names. I see there being some freedom when the interface is a split transaction interface (like AXI) and multiple layers of records are used.

We decided to adopt full UpperCamelCase names (Cycle, Strobe, Acknowledge, WriteEnable, etc.) instead of the abbreviated spec names. The spec signal names are still documented in comments for reference, so the mapping should be clear to anyone familiar with Wishbone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement New feature or request Internal Mainly internal interface between components. Memory-Mapped SoC Bus Architecture

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WB - Wishbone

3 participants