Structured logging with open telemetry semantic conventions #118
Open
clintjeff2 wants to merge 3 commits into
Open
Conversation
Add OpenTelemetry structured logging events (otel.log)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
OtelLogRecordcontracttype andemit_otel_loghelper to publish a singleotel.logevent with a 100 mscritical_path_budget_msfield incontracts/utility_contracts/src/lib.rs.meter.registered,meter.top_up,provider.claim, andusage.updated.OtelLogRecordfields and thatemit_otel_logpublishes theotel.logevent incontracts/utility_contracts/src/otel_logging_tests.rs.contracts/docs/specs/otel-structured-logging.md.Testing
rustfmton the new test file successfully.cargo test --manifest-path contracts/utility_contracts/Cargo.toml otel_logging_tests --lib, but execution was blocked by pre-existing, unrelated compile errors in theutility_contractscrate so the new tests could not be fully validated.cargo check --manifest-path contracts/utility_contracts/Cargo.toml --lib, which also surfaced unrelated compile failures in the crate (duplicate constant, symbol length issues, and several pre-existing API/signature mismatches).Closes #73