Make email optional on customer update #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
The change to |
peter279k
reviewed
Aug 31, 2019
peter279k
left a comment
peter279k
left a comment
There was a problem hiding this comment.
It looks good.
Could you have some tests about these code changes?
It will make sure that the behavior will be expected.
Author
|
Better late than never. 😄Just pushed up a test. |
peter279k
approved these changes
Jan 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't require email to be sent on a customer update request. With the API, if you have the ID, it is possible to update attributes without having to specify email, so that should be allowed here as well.