Skip to content
This repository was archived by the owner on Jul 6, 2026. It is now read-only.
This repository was archived by the owner on Jul 6, 2026. It is now read-only.

Invalid check for Lucky Miner LV07 #408

Description

@chrigublaser

Describe the bug
Lucky Miner LV07 devices are not being recognized due to an incorrect string check for this model in factory.py.
The current logic checks for "Lucky miner" (lowercase m), which works for LV08, but the LV07 returns "Lucky Miner" (uppercase M) in web_text, causing identification to fail.

To Reproduce

  1. Install pyasic following the Getting Started guide.
  2. Fetch miner information by IP as described in:
    https://github.com/UpstreamData/pyasic?tab=readme-ov-file#creating-miners-based-on-ip
  3. Observe that the miner is not recognized → result is None.

Expected behavior
The miner should be detected and identified as Lucky Miner LV07 (Stock).

Miner Information (If applicable):

  • Manufacturer: Lucky Miner
  • Type: LV07
  • Firmware Type: Stock
  • Firmware Version: 1.1.0

Additional context
pyasic calls _get_miner_web from factory.py to retrieve miner data and determine the miner type.
For Lucky Miner devices, the detection relies on the presence of "Lucky miner" in web_text.

LV08 web_text contains: "Lucky miner" → recognized correctly
LV07 web_text contains: "Lucky Miner" → not recognized due to case-sensitive match

This causes LV07 miners to go unidentified.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions