created simple gallery page grid and header#212
Merged
Conversation
|
🚀 Preview deployment is live: Preview Link |
yrska
requested changes
May 16, 2026
Collaborator
yrska
left a comment
yrska
left a comment
There was a problem hiding this comment.
The code itself looks great!
However, it may be more conventional and better practice if we extract the header into its own component, perhaps something like:
<GalleryHeader title="Full Gallery" />
where it has its own file!
We could also temporarily place the placeholder images into their own file (perhaps something like a GalleryData.tsx file, which we can remove once we stop hardcoding images!
Contributor
Author
|
Everything should work completely fine in this version, I have also added responsiveness to the grid ;) |
yrska
approved these changes
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #<issue_number>
🌟 Context
Completing first task on gallery
📝 Description
Making responsive 4 column gallery with placeholder images
📋 Notes