feat: audio playback on scenario#406
Merged
Merged
Conversation
harbassan
force-pushed
the
vps-25-scenario-audio-implementation
branch
from
d7e52ba to
edc1ad7
Compare
harbassan
force-pushed
the
vps-25-scenario-audio-implementation
branch
from
edc1ad7 to
60bb335
Compare
harbassan
force-pushed
the
vps-25-scenario-audio-implementation
branch
from
60bb335 to
5f39268
Compare
br-Chan
reviewed
May 21, 2026
| </div> | ||
| )} | ||
| {!audioAllowed && ( | ||
| <div className="absolute top-4 left-4 z-30"> |
There was a problem hiding this comment.
Not familiar with this part of the code, why is there a z-30 here?
Contributor
There was a problem hiding this comment.
i think to make sure its always on top when it comes to elements on the screen, but yea not the best way. I approved incase we want this for the milestone
I just read this, haha. Sounds good, and I suppose if you want to come back later and improve it then just make a note of it so we don't forget, otherwise LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Very basic audio implementation for the PlayScenarioPage does not exist.
Solution
The audios attached to the scene will now play, once the user has enabled audio for the scenario. This explicit enable is required due to browser laws, which are there to protect the user from unwanted playback. After the enable the rest of the scenario will autoplay audios.
Risk
I did this very hastily and just did basic testing. It does work but it is probably not the most efficient way to do this.
Checklist