Vps 9/conditions in collections#393
Open
rgin216 wants to merge 4 commits into
Open
Conversation
…iables return true for file to be visible
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Resource collections could not have their own state conditions. Authors could only conditionally reveal individual files, which made it awkward to reveal a whole collection of related resources at once. The old CollectionChild model was also unused.
Solution
Added stateConditionals to collection groups, with create/update/delete API support. Generalized the existing state conditional UI so it can target either a file or a collection. Player resource filtering now requires both collection-level and file-level conditions to pass before a file is visible.
Also removed the unused CollectionChild model after confirming it had no references.
Risk
Collection-level conditions add another visibility gate, so incorrectly configured collection conditions can hide files that would previously have appeared based only on file-level conditions. Existing collections without conditions should continue to behave as before.
Checklist