EEPROM/RTC manager: auto-sync on reset, SN display, per-module sections#10
Merged
Conversation
Member
Author
|
@copilot resolve the merge conflicts in this pull request |
Co-authored-by: roman-dvorak <5196729+roman-dvorak@users.noreply.github.com>
…le return Agent-Logs-Url: https://github.com/UniversalScientificTechnologies/dosview/sessions/241e2147-c2be-4d85-9e4f-798134fdd010 Co-authored-by: roman-dvorak <5196729+roman-dvorak@users.noreply.github.com>
Contributor
Merge conflicts resolved in 8bbdf2c. There was one conflicting file (
Also updated |
# Conflicts: # dosview/eeprom_widget.py # tests/test_parser.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant improvements to the EEPROM Manager UI and logic, enhancing support for different module types ("detector" and "battery") and improving user experience. The changes include dynamic UI adjustments based on module type, accurate handling and display of calibration coefficients as float32, addition of serial number reading, and improved RTC synchronization handling. Below are the most important changes grouped by theme:
Module Type Awareness and Dynamic UI:
The
EepromManagerWidgetand related functions now accept amodule_typeparameter ("detector" or "battery"), allowing the UI and logic to adapt based on the connected hardware. This affects which configuration/calibration fields are shown, ensuring only relevant options appear for each module type. [1] [2] [3] [4] [5] [6] [7] [8]RTC synchronization fields are now only visible for battery modules, while calibration fields are only shown for detector modules. Hidden fields are created for compatibility when not displayed, preserving data integrity when reading/writing. [1] [2]
Calibration and Float32 Handling:
Calibration coefficients are now handled as float32 values, both in parsing and display. The UI uses text fields with scientific notation support, and values are rounded and formatted to true float32 precision for accurate round-trip representation. [1] [2] [3] [4] [5]
Added a "Now" button to quickly set the current Unix timestamp for calibration, improving usability. [1] [2]
Serial Number Reading:
Improved Error Handling and Feedback:
Added error messages for missing HID interfaces during device connection, improving diagnostics when hardware is not detected.
Improved status messages and error handling throughout the EEPROM Manager and RTC Manager, including clear feedback for file loads, device loads, and RTC operations. [1] [2]
RTC Manager Enhancement: