Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions backend/__tests__/api/controllers/leaderboard.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -358,6 +358,36 @@ describe("Loaderboard Controller", () => {
true,
);
});
it("should get null if no rank", async () => {
//GIVEN
await enableConnectionsFeature(true);
getLeaderboardRankMock.mockResolvedValue(null);

//WHEN
const { body } = await mockApp
.get("/leaderboards/rank")
.query({
language: "english",
mode: "time",
mode2: "60",
friendsOnly: true,
})
.set("Authorization", `Bearer ${uid}`)
.expect(200);

//THEN
expect(getLeaderboardRankMock).toHaveBeenCalledWith(
"time",
"60",
"english",
uid,
true,
);
expect(body).toEqual({
message: "Rank retrieved",
data: null,
});
});
it("should get with ape key", async () => {
await acceptApeKeys(true);
const apeKey = await mockAuthenticateWithApeKey(uid, await configuration);
Expand Down
9 changes: 5 additions & 4 deletions backend/src/api/controllers/leaderboard.ts
Original file line number Diff line number Diff line change
Expand Up @@ -98,10 +98,11 @@ export async function getRankFromLeaderboard(
);
}

return new MonkeyResponse(
"Rank retrieved",
omit(data as LeaderboardsDAL.DBLeaderboardEntry, ["_id"]),
);
if (data === null) {
return new MonkeyResponse("Rank retrieved", null);
}

return new MonkeyResponse("Rank retrieved", omit(data, ["_id"]));
}

function getDailyLeaderboardWithError(
Expand Down
Loading