Skip to content

Update readme: configuring and compilation#116

Open
peteruithoven wants to merge 3 commits intoUltimaker:masterfrom
peteruithoven:patch-1
Open

Update readme: configuring and compilation#116
peteruithoven wants to merge 3 commits intoUltimaker:masterfrom
peteruithoven:patch-1

Conversation

@peteruithoven
Copy link
Copy Markdown

Crude attempt at updating the readme regarding configuring and compilation

Crude attempt at updating the readme regarding configuring and compilation
README.md Outdated
```
Use the Makefile to compile & upload the firmware, for example:
```
make UPLOAD_PORT=/dev/ttyACM0
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need the upload_port for the make command :) can you verify this and then update your PR/

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, you where right, didn't need it. I updated the example.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And while i'm typing 'could you also just squash your commits into one' I realized this was about UM2 marlin firmware, which as far as I recall, can still be built using Arduino. So maybe add it as an alternative/optional flow.

Sorry for bike shedding over such a simple change.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tricky since I never tried this with the Arduino IDE. I just kept the basics intact. I did choose for cloning, since that makes development and contributing easier.

I understand it's now possible for the maintainers of Github repo's to squash commits when merging; https://github.com/blog/2141-squash-your-commits

Let me know if you want other tweaks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants