fix: avoid OpenTelemetry context detach errors in mock runtimes#74
Merged
cristipufu merged 1 commit intomainfrom Feb 17, 2026
Merged
Conversation
…generators Replace start_as_current_span() with start_span() + try/finally for spans that wrap yield statements in async generators. The context manager variant attaches/detaches context tokens, which fails when GeneratorExit is raised at a yield point (e.g. client disconnect) because the detach happens in a different asyncio context than the original attach. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
start_as_current_span()withstart_span()+try/finally: span.end()for spans that wrapyieldstatements in async generators across all 6 mock runtime filesopentelemetry.context: Failed to detach contexterrors caused byGeneratorExitbeing raised at yield points inside span context managers, where the context detach runs in a different asyncio context than the original attachTest plan
Failed to detach contexterrors in logs🤖 Generated with Claude Code