chore(repo): add advanced security with supression & fix issues#160
chore(repo): add advanced security with supression & fix issues#160CalinaCristian merged 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a custom CodeQL workflow to support in-source alert suppression using lgtm[...] comments, and updates existing code/workflows to address remaining CodeQL security alerts.
Changes:
- Added a custom
.github/workflows/codeql.ymlto run CodeQL (Actions + JS/TS) with alert suppression query pack enabled. - Hardened CI workflows (
release.yml,vercel-deploy.yml) to reduce credential persistence and narrow secret exposure patterns. - Replaced inline
codeql[...]suppression comments withlgtm[...]suppressions in a few code/test locations.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/codeql.yml |
New CodeQL workflow with suppression pack and pinned action SHAs. |
.github/workflows/release.yml |
Disables checkout credential persistence and adjusts git push authentication. |
.github/workflows/vercel-deploy.yml |
Changes how Vercel project ID secrets are provided per matrix job. |
web-packages/ap-chat/src/dev.ts |
Switches CodeQL suppression comment to lgtm[...] for dev-only innerHTML. |
packages/apollo-wind/src/components/forms/data-fetcher.ts |
Switches CodeQL suppression comments to lgtm[...] around new Function(). |
packages/apollo-react/src/test/canvas-mocks.ts |
Switches CodeQL suppression to lgtm[...] for a test mock. |
packages/apollo-core/scripts/test/sanitize-svg.test.ts |
Switches CodeQL suppressions to lgtm[...] in test-only sanitization logic. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
5180721 to
d91f741
Compare
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
d91f741 to
05623d8
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
05623d8 to
84ffd69
Compare
84ffd69 to
26510c3
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Comments suppressed due to low confidence (1)
.github/workflows/release.yml:93
- The
http.https://github.com/.extraheadervalue is not actually set the same way asactions/checkout. For git HTTPS auth, GitHub expects a Basic auth header (as used byactions/checkout), notAUTHORIZATION: token ...; this will likely causegit pushto fail. Update the extraheader to use the checkout-style Basic header (e.g., base64-encodedx-access-token:<token>), or alternatively avoid reconfiguring auth and let checkout manage it (while still preventing persisted credentials).
git add --all
git commit -m "chore(release): version bump [skip ci]" -m "Packages: $CHANGED_PACKAGES"
git push
else
echo "No changes to commit"
fi
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Current Stack
Managed with stacked-prs |
🔒 Enable CodeQL Alert Suppression + Fix Remaining Security Alerts
Adds custom CodeQL workflow to enable in-source alert suppression via
lgtm[...]comments, and fixes the last outstanding security alerts.Changes
New Workflow
.github/workflows/codeql.yml- Custom CodeQL analysis with:AlertSuppression.qlpack)persist-credentials: falsehardeningSecurity Fixes (3 alerts)
Alert #75 - Credential Persistence (
release.yml)persist-credentials: falseto checkoutAlert #1 & #64 - Secrets Exposure (
vercel-deploy.yml)secrets[matrix.vercel_project_id_secret]with explicit mappingWhy This Matters
Alert Suppression:
AlertSuppression.qlqueries// lgtm[query-id]comments are ignoredSecurity Improvements:
Testing