feat(apollo-vertex): add language switcher [AGVSOL-1055, AGVSOL-1045] by alincadariu · Pull Request #133 · UiPath/apollo-ui

alincadariu · 2026-01-28T13:52:25Z

The goal: consumer would only need to provide the translation files.

This PR adds:

Locale provider
type safety for translation keys
i18n initialization
language switcher

github-actions · 2026-01-28T13:52:36Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Review	Updated (PT)
apollo-canvas	🟢 Ready	Preview, Logs	Feb 04, 2026, 03:11:32 AM
apollo-ui-react	🟢 Ready	Preview, Logs	Feb 04, 2026, 03:10:28 AM
apollo-vertex	🟢 Ready	Preview, Logs	Feb 04, 2026, 03:09:52 AM
apollo-wind	🟢 Ready	Preview, Logs	Feb 04, 2026, 03:09:29 AM

github-actions · 2026-01-28T13:52:58Z

🤖 AI Code Review (Claude)

⚠️ Automated Review: This is an AI-generated review. Use as guidance, not gospel.

Code Review: Add Language Switcher to Apollo Vertex Shell

Summary

This PR adds a language toggle component to the Apollo Vertex shell, allowing users to switch between 13 supported languages. The component is integrated into the sidebar (both collapsed and expanded states) and dispatches custom events for i18n integration.

Code Quality ✅

The implementation is clean and well-structured:

✅ Component properly separated into language-toggle.tsx
✅ Props threading through shell layers is correct
✅ Good documentation with usage examples in MDX
✅ Proper handling of both sidebar states (collapsed/expanded)

Minor observation (non-blocking): The setLanguage callback has an empty dependency array but should include any dependencies if the component is used in different contexts. Current implementation is acceptable for this use case.

Security ✅

No security concerns identified:

✅ No XSS vulnerabilities - locale codes and names are from trusted configuration
✅ Custom event dispatch is safe - only dispatches locale code (string)
✅ No external data or user input being processed unsafely

Type Safety ✅

TypeScript usage is appropriate:

✅ Proper interface definitions for LanguageToggleProps and ApolloShellProps
✅ Props correctly typed through component chain
✅ Event handling could be more strongly typed but is acceptable

Suggestion (non-blocking): Consider creating a typed event interface:

export interface LanguageChangedEvent extends CustomEvent {
  detail: { selectedLanguageId: string };
}

Testing ⚠️

As per project guidelines, tests are not required for playground apps (apps/ folder). This is acceptable.

Performance ✅

No performance concerns:

✅ useCallback appropriately used for event dispatch
✅ Component is lightweight (dropdown with 13 items)
✅ Local state management is simple and efficient

Additional Notes

Positive aspects:

Comprehensive language support (13 locales including regional variants)
Accessible design with sr-only label
Visual feedback for selected language (bg-accent)
Good integration pattern with i18n systems via custom events
Documentation includes practical integration example

Minor observations (non-blocking):

The next-env.d.ts change (.next/types/routes.d.ts → .next/dev/types/routes.d.ts) appears to be an auto-generated Next.js internal change - this is fine
Consider persisting the selected language (e.g., localStorage) in future iterations for better UX

Recommendation: APPROVE ✅

This PR is well-implemented, secure, and ready to merge. The language switcher component follows good patterns, integrates cleanly with the existing shell, and provides a solid foundation for i18n support. The code quality is high and appropriate for a playground/showcase application.

This automated review is temporary for solo development. Will be replaced with human reviews once the team grows.

github-actions

✅ AI Review: Changes look good. Auto-approved by Claude AI.

github-actions