Skip to content

refactor: increase plugin timeout #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FlandiaYingman merged 1 commit into from
Dec 3, 2025
Merged

refactor: increase plugin timeout #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/app.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,12 @@ function getOption(

// Pass --options via CLI arguments in command to enable these options.
const options: AppOptions = {
// Launching lots of services on the server,
// especially at the same time by something such as docker compose up,
// leads to slow startups.
// This increases the timeout for plugins to 5 minutes.
pluginTimeout: 5 * 60 * 1000,
Comment on lines +46 to +47
Copy link

Copilot AI Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The plugin timeout is hardcoded to 5 minutes. Consider making this configurable via an environment variable (e.g., PLUGIN_TIMEOUT) to allow for flexibility across different deployment environments without requiring code changes. This follows the pattern already established in the codebase with other configuration options like AUTH_DISCOVERY_URL and AUTH_CLIENT_ID.

Example:

pluginTimeout: parseInt(getOption("PLUGIN_TIMEOUT", false) || "300000", 10),
Suggested change
// This increases the timeout for plugins to 5 minutes.
pluginTimeout: 5 * 60 * 1000,
// This increases the timeout for plugins to 5 minutes, or can be overridden with PLUGIN_TIMEOUT env var.
pluginTimeout: parseInt(getOption("PLUGIN_TIMEOUT", false) || "300000", 10),

Copilot uses AI. Check for mistakes.

// mongoUri: getOption("MONGO_URI")!,
authDiscoveryURL: getOption("AUTH_DISCOVERY_URL")!,
authClientID: getOption("AUTH_CLIENT_ID")!,
Expand Down