feat: start week view at the smallest subject hour of the day#48
Open
iDavi wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey pessoal, espero que esteja tudo ok por aí.
Não sei se abrir um PR é de bom tom (peço desculpas se não for o caso), mas vi a issue #45 e tive essa ideia. Essa mudança faz a primeira hora exibida na aba Week ser dinâmica (a menor possível).
Isso não corrige o problema da issue para todos os casos (que, pelo que eu vi, já está sendo corrigido em fix/task-overlap-issue) mas elimina um grande espaço vazio que aparece no layout para alunos que só tem disciplinas no período noturno, facilitando a visualização. Essa mesma lógica é usada na grade do JupiterWeb, por exemplo.
Antes:


Depois:
Detalhes da implementação:
firstHour: menor hora de início entre as matérias.totalHours = 18: janela fixa de 18h, pra manter os containers com os nomes das disciplinas do mesmo tamanho que são hoje.também refatorei
calculateDayHeightecalculateDayTop, trocando o número magico por uma escala derivada detotalMinutes