Beach width mods - #58
Open
avanblunk wants to merge 21 commits into
Open
Conversation
…each_dune_manager.py so that all modules that apply nourishment are altering the same beach. beach_dune_manager and outwasher are now initialized with the common beach_width and beach_width_threshold variables
…Outwasher. ran tests and all passed.
… test variables. when running cascade with nourishment and outwash, the beach_width variables for all three were the same (as they should be).
…Cascade class, BeachDuneManager class, and Outwasher class
….004 to beta so the outwash beach that is created matches the user's input parameters better
anardek
reviewed
Sep 2, 2026
anardek
reviewed
Sep 2, 2026
anardek
requested changes
Sep 2, 2026
flake8 update Co-authored-by: K Anarde <57640439+anardek@users.noreply.github.com>
for more information, see https://pre-commit.ci
flake8 update Co-authored-by: K Anarde <57640439+anardek@users.noreply.github.com>
for more information, see https://pre-commit.ci
typo in nourishment
forgot to update the call to the function after renaming it
…width updates to account for his user defined beach width variable also had to add outwasher back into the import lines
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
modified the "fake" beach width variable that is created anytime a nourishment occurs. BeachDuneManager and Outwasher both nourish the shoreface, which changes the barrier3d shoreline position and creates a beach. this beach halts dune migration until it is eroded back to the dune line, then dune migration turns back on. originally, the beach created in BeachDuneManager was independent of the beach created in Outwasher, but now there is a cascade beach width variable that passes information between the modules. the cascade beach width is input into BeachDuneManager and Outwasher, and gets updated after each module runs.