Repository navigation
revert(dts-generator): revert add getOriginalProperty declarations and tests to TypedJSONModel - #537
Merged
Merged
Conversation
|
|
…d tests to TypedJSONModel This reverts commit ae4ba2e.
viktorsperling
changed the title
PeterBuchholz
approved these changes
Jan 26, 2026
|
LGTM |
Member
|
What is the reason for the revert? |
Collaborator
Author
We decided to deprecate the |
codeworrior
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit ae4ba2e as
getOriginalPropertyonly callsgetPropertyfor the JSONModel (this is different in other Model implementations, e.g. ODataModel).Therefore, we decided to deprecate those APIs (
getObject&getOriginalProperty) for the JSONModel and should not support it on the TypedJSONModel, too.